va|Accuracy Wars - NEW SERVER MOD!

[va|DeathStar]

Server Name
va|Accuracy Wars

How it works
If anyone gets higher than 50% accuracy, they get +40 health each time someone dies.
When their accuracy drops below 50% again, the health boost goes away.

Fun mode ideas
efficctf - a flagcarrier that is healthboosted because of high accuracy can sustain for a long time.

effichold - if you're accurate, you can be an amazing flagholder, you will keep regenerating health.

effic - snipers rule accuracy wars efficctf. Any high accuracy player will be rewarded heavily.

regen capture - the rifle base will be the most demanded base in the whole game, like a capture point.

collect - collecting the skulls will be easy with a healthboost.

tactics - since weapons are supplied randomly, the healthboosted people will most likely be random too.

ffa - this would be the most difficult to get high accuracy on. Rifle pickups rule.

insta - this mod doesn't work well in insta because the health isn't restored. Avoid this mode.

Pass the flag
you can pass the flag in accuracy wars. This allows the game to progress more rapidly.

Ideas?
If you have ideas for another mod that you'd like to see, please post a reply and I will work on it, seriously.
I have been considering linking hulk mode with accuracy wars but I don't know what people want.

The code
 void checkbestacc() {
        loopv(clients) {
            clientinfo *ci = clients;
            if(!ci->CheckedBestAcc && ci->connected && ci->clientnum < 128) {
                int cacc = clients->state.damage * 100 / max(clients->state.shotdamage, 1);
                if(cacc > 50) {
                    defformatstring(sc)("You are accurate (%d%%), giving you +40 health!",cacc);
                    sendf(ci->clientnum,1,"ris",N_SERVMSG,sc);
                    ci->state.health = ci->state.health+40;
                    ci->CheckedBestAcc = true;
                }
            }
        }
    }

[Timon]

Why do you use "clients->" instead of "ci->" in some parts? (makes code looks confusing)

CheckedBestAcc variable looks like you're trying to to call checkbestacc() function in the server mainloop (or it's not going to add +40 hp each time someone is dying). See no sense. Would be easier to process that logic just inside server damaging/death procedure.

Why bots are excluded? If you do everything right, you won't get segfaults about it. (Just don't send them N_SERVMSG messages)

Thought would be better to reset player accuracy every death.

[va|DeathStar]

checkbestacc is being called from dodamage under ts.health 0 so no need to reset acc.

clients loops through all the clients.

ci is an abréviation for clientinfo. ci->state is one thing and clients is another.

[Timon]

checkbestacc is being called from dodamage under ts.health 0 so no need to reset acc.

clients loops through all the clients.

ci is an abréviation for clientinfo. ci->state is one thing and clients is another.

If it's called from dodamage, then you can immediately check accuracy, and add health if target died. Variable CheckedBestAcc is not needed

Code: [Select]

"clients[i]" same as "ci" in your code
Have no idea why do you mix them.
Replace all "clients[i]->" to "ci->", it's gotta work the same way.
But well, it's only matter of formalization, doesn't really affects to anything.


[Doko]

The idea sounds fun, but unbalanced. Think about the people that sucks in insta, this gamemode will not be played by any of them because there is not any incentive for the guys with lower accuracy. They are destined to die and suck, meanwhile the good ones can kill easly and at the same time get stronger, so, it's practically a raping mod.
Greetings.